linux-kernel - Re: [PATCH] serio: avoid negative serio device numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141008222200.GH15198@dtor-ws>
Date:	Wed, 8 Oct 2014 15:22:00 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Richard Leitner <me@...l1n.net>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	richard.leitner@...data.com
Subject: Re: [PATCH] serio: avoid negative serio device numbers

On Wed, Oct 08, 2014 at 11:54:27PM +0200, Richard Leitner wrote:
> From: Richard Leitner <richard.leitner@...data.com>
> 
> Fix the format string for serio device name generation to avoid negative
> device numbers when the id exceeds the maximum signed integer value.
> 
> Signed-off-by: Richard Leitner <richard.leitner@...data.com>

Applied, thank you.

> ---
>  drivers/input/serio/serio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> index b29134d..d399b8b 100644
> --- a/drivers/input/serio/serio.c
> +++ b/drivers/input/serio/serio.c
> @@ -524,8 +524,8 @@ static void serio_init_port(struct serio *serio)
>  	spin_lock_init(&serio->lock);
>  	mutex_init(&serio->drv_mutex);
>  	device_initialize(&serio->dev);
> -	dev_set_name(&serio->dev, "serio%ld",
> -			(long)atomic_inc_return(&serio_no) - 1);
> +	dev_set_name(&serio->dev, "serio%lu",
> +		     (unsigned long)atomic_inc_return(&serio_no) - 1);
>  	serio->dev.bus = &serio_bus;
>  	serio->dev.release = serio_release_port;
>  	serio->dev.groups = serio_device_attr_groups;
> -- 
> 2.1.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/