linux-kernel - Re: [PATCH] regulator: of: Lower the severity of the error with no container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141008223403.GA24828@roeck-us.net>
Date:	Wed, 8 Oct 2014 15:34:03 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org,
	linaro-kernel@...ts.linaro.org, atull@...nsource.altera.com
Subject: Re: [PATCH] regulator: of: Lower the severity of the error with no
 container

On Wed, Oct 08, 2014 at 11:09:59PM +0100, Mark Brown wrote:
> Description of regulators should generally be optional so if there is no
> DT node for the regulators container then we shouldn't print an error
> message. Lower the severity of the message to debug level (it might help
> someone work out what went wrong) and while we're at it say what we were
> looking for.
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Signed-off-by: Mark Brown <broonie@...nel.org>

Excellent.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Would it also be possible to lower the severity of the "no parameters"
message ?

Thanks,
Guenter

> ---
>  drivers/regulator/of_regulator.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
> index 7a51814abdc5..5a1d4afa4776 100644
> --- a/drivers/regulator/of_regulator.c
> +++ b/drivers/regulator/of_regulator.c
> @@ -211,7 +211,8 @@ struct regulator_init_data *regulator_of_get_init_data(struct device *dev,
>  		search = dev->of_node;
>  
>  	if (!search) {
> -		dev_err(dev, "Failed to find regulator container node\n");
> +		dev_dbg(dev, "Failed to find regulator container node '%s'\n",
> +			desc->regulators_node);
>  		return NULL;
>  	}
>  
> -- 
> 2.1.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/