linux-kernel - Re: [PATCH] staging: bcm: remove unnecessary else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141008224023.GB9464@kroah.com>
Date:	Wed, 8 Oct 2014 15:40:23 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Karthik Nayak <karthik.188@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	gamerh2o@...il.com, mark.einon@...il.com
Subject: Re: [PATCH] staging: bcm: remove unnecessary else statement

On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
> Removed the else statement occurring after an if statement with a
> return value as per checkpatch warning.
> 
> Signed-off-by: Karthik Nayak <karthik.188@...il.com>
> ---
>  drivers/staging/bcm/InterfaceMisc.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/bcm/InterfaceMisc.c b/drivers/staging/bcm/InterfaceMisc.c
> index e5bcfec..1f31b8f 100644
> --- a/drivers/staging/bcm/InterfaceMisc.c
> +++ b/drivers/staging/bcm/InterfaceMisc.c
> @@ -102,12 +102,11 @@ int InterfaceWRM(struct bcm_interface_adapter *psIntfAdapter,
>  				DBG_LVL_ALL, "WRM failed status :%d", retval);
>  		psIntfAdapter->psAdapter->DeviceAccess = false;
>  		return retval;
> -	} else {
> -		psIntfAdapter->psAdapter->DeviceAccess = false;
> -		BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> -				DBG_LVL_ALL, "WRM sent %d", retval);
> -		return STATUS_SUCCESS;
>  	}
> +	psIntfAdapter->psAdapter->DeviceAccess = false;
> +	BCM_DEBUG_PRINT(psIntfAdapter->psAdapter, DBG_TYPE_OTHERS, WRM,
> +			DBG_LVL_ALL, "WRM sent %d", retval);
> +	return STATUS_SUCCESS;
>  }
>  
>  int BcmRDM(void *arg,
> -- 
> 2.1.0

This doesn't apply either, someone else must have done this change
already.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/