linux-kernel - Re: [PATCH v4 21/29] nios2: Time keeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Oct 2014 17:00:41 +0800
From:	Ley Foon Tan <lftan@...era.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Linux-Arch <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Chung-Lin Tang <cltang@...esourcery.com>
Subject: Re: [PATCH v4 21/29] nios2: Time keeping

On Wed, Oct 8, 2014 at 6:44 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Wed, 8 Oct 2014, Ley Foon Tan wrote:
>> +static void nios2_timer_set_mode(enum clock_event_mode mode,
>> +     struct clock_event_device *evt)
>> +{
>> +     unsigned long period;
>> +     struct nios2_clockevent_dev *nios2_ced = to_nios2_clkevent(evt);
>> +     struct nios2_timer *timer = &nios2_ced->timer;
>> +
>> +     switch (mode) {
>> +     case CLOCK_EVT_MODE_PERIODIC:
>> +             period = DIV_ROUND_UP(timer->freq, HZ);
>> +             nios2_timer_config(timer, period, CLOCK_EVT_MODE_PERIODIC);
>> +             break;
>> +     case CLOCK_EVT_MODE_ONESHOT:
>> +             nios2_timer_config(timer, ULONG_MAX, CLOCK_EVT_MODE_ONESHOT);
>
> What's the point of this? This should simply stop the timer.
Okay, will change this.

Regards
Ley Foon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/