| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20141009102341.GU23154@mwanda> Date: Thu, 9 Oct 2014 13:23:41 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Sudip Mukherjee <sudipm.mukherjee@...il.com> Cc: Daeseok Youn <daeseok.youn@...il.com>, devel@...verdev.osuosl.org, lidza.louina@...il.com, driverdev-devel@...uxdriverproject.org, linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org Subject: Re: [PATCH V2] staging: dgap: introduce dgap_stop() On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote: > On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote: > > The dgap_init_module() need to unwind for cleanup variables properly. > > Because dgap_init_module() calls dgap_cleanup_module() for freeing > > variables but this function is possible to free variables > > which are not allocated. > > > > Signed-off-by: Daeseok Youn <daeseok.youn@...il.com> > > --- > > V2: change ulong which is non-standard to "unsigned long". > I think , Dan, in his review of your v1 , asked you to rearrange the functions and get rid of the forward declarations. > I was fine with v1 actually... It's a bug fix, and this is staging and there are tons of forward declarations already. Eventually we need to get rid of them but it can be done later. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists