linux-kernel - Re: [PATCH] serial: 8250_dw: Add DMA support for non-ACPI platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141009132042.GC9108@kuha.fi.intel.com>
Date:	Thu, 9 Oct 2014 16:20:42 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Ray Jui <rjui@...adcom.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Chen-Yu Tsai <wens@...e.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Loic Poulain <loic.poulain@...el.com>,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	JD Zheng <jdzheng@...adcom.com>,
	Scott Branden <sbranden@...adcom.com>
Subject: Re: [PATCH] serial: 8250_dw: Add DMA support for non-ACPI platforms

On Tue, Oct 07, 2014 at 05:35:47PM -0700, Ray Jui wrote:
> The dma pointer under struct uart_8250_port is currently left
> unassigned for non-ACPI platforms. It should be pointing to the dma
> member in struct dw8250_data like how it was done for ACPI, so the core
> 8250 code will try to request for DMA when registering the port
> 
> If DMA is not enabled in device tree, request DMA will fail and the
> driver will fall back to PIO
> 
> Signed-off-by: Ray Jui <rjui@...adcom.com>
> Reviewed-by: JD (Jiandong) Zheng <jdzheng@...adcom.com>
> Reviewed-by: Scott Branden <sbranden@...adcom.com>
> Tested-by: Scott Branden <sbranden@...adcom.com>

OK by me. FWIW..

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>


-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/