linux-kernel - Re: [PATCH] usb: gadget: f_fs: remove redundant ffs_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141009142117.GB16002@saruman>
Date:	Thu, 9 Oct 2014 09:21:17 -0500
From:	Felipe Balbi <balbi@...com>
To:	Robert Baldyga <r.baldyga@...sung.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<mina86@...a86.com>, <andrzej.p@...sung.com>,
	<m.szyprowski@...sung.com>
Subject: Re: [PATCH] usb: gadget: f_fs: remove redundant ffs_data_get()

On Thu, Oct 09, 2014 at 09:41:16AM +0200, Robert Baldyga wrote:
> During FunctionFS bind, ffs_data_get() function was called twice
> (in functionfs_bind() and in ffs_do_functionfs_bind()), while on unbind
> ffs_data_put() was called once (in functionfs_unbind() function).
> In result refcount never reached value 0, and ffs memory resources has
> been never released.
> 
> Since ffs_data_get() call in ffs_do_functionfs_bind() is redundant
> and not neccessary, we remove it to have equal number of gets ans puts,
> and free allocated memory after refcount reach 0.
> 
> Signed-off-by: Robert Baldyga <r.baldyga@...sung.com>

Which commit is this fixing ? does it deserve a stable backport ? How
far back ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)