lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Oct 2014 08:54:04 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Lee Jones <lee.jones@...aro.org> Cc: Catalin Marinas <catalin.marinas@....com>, "linux-m32r-ja@...linux-m32r.org" <linux-m32r-ja@...linux-m32r.org>, "linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>, "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>, "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>, Linus Walleij <linus.walleij@...aro.org>, "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>, "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>, "lguest@...ts.ozlabs.org" <lguest@...ts.ozlabs.org>, "linux-c6x-dev@...ux-c6x.org" <linux-c6x-dev@...ux-c6x.org>, "linux-hexagon@...r.kernel.org" <linux-hexagon@...r.kernel.org>, "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>, "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>, "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "user-mode-linux-devel@...ts.sourceforge.net" <user-mode-linux-devel@...ts.sourceforge.net>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "adi-buildroot-devel@...ts.sourceforge.net" <adi-buildroot-devel@...ts.sourceforge.net>, "linux-m68k@...r.kernel.org" <linux-m68k@...r.kernel.org>, "linux-am33-list@...hat.com" <linux-am33-list@...hat.com>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "openipmi-developer@...ts.sourceforge.net" <openipmi-developer@...ts.sourceforge.net>, "linux-metag@...r.kernel.org" <linux-metag@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, Samuel Ortiz <sameo@...ux.intel.com>, "linux-parisc@...r.kernel.org" <linux-parisc@...r.kernel.org>, "linux-cris-kernel@...s.com" <linux-cris-kernel@...s.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-alpha@...r.kernel.org" <linux-alpha@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org> Subject: Re: [PATCH 12/44] mfd: ab8500-sysctrl: Register with kernel poweroff handler On Thu, Oct 09, 2014 at 11:49:27AM +0100, Lee Jones wrote: > On Thu, 09 Oct 2014, Catalin Marinas wrote: > > > On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote: > > > On Mon, 06 Oct 2014, Guenter Roeck wrote: > > > > --- a/drivers/mfd/ab8500-sysctrl.c > > > > +++ b/drivers/mfd/ab8500-sysctrl.c > > > > @@ -6,6 +6,7 @@ > > > > > > [...] > > > > > > > +static int ab8500_power_off(struct notifier_block *this, unsigned long unused1, > > > > + void *unused2) > > > > { > > > > sigset_t old; > > > > sigset_t all; > > > > @@ -34,11 +36,6 @@ static void ab8500_power_off(void) > > > > struct power_supply *psy; > > > > int ret; > > > > > > > > - if (sysctrl_dev == NULL) { > > > > - pr_err("%s: sysctrl not initialized\n", __func__); > > > > - return; > > > > - } > > > > > > Can you explain the purpose of this change please? > > > > I guess it's because the sysctrl_dev is already initialised when > > registering the power_off handler, so there isn't a way to call the > > above function with a NULL sysctrl_dev. Probably even with the original > > code you didn't need this check (after some race fix in > > ab8500_sysctrl_remove but races is one of the things Guenter's patches > > try to address). > > Sounds reasonable, although I think this change should be part of > another patch. > Turns out the options are to either drop the check or to use the device managed function to register the poweroff handler. I decided to keep the check and use the device managed function. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists