linux-kernel - Re: [PATCH] net sched: text ematch: zero out ts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141009162829.GA20290@mew.home.network>
Date:	Thu, 9 Oct 2014 09:28:29 -0700
From:	Omar Sandoval <osandov@...ndov.com>
To:	Jamal Hadi Salim <jhs@...atatu.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net sched: text ematch: zero out ts_state before using it

On Thu, Oct 09, 2014 at 09:05:21AM -0700, Omar Sandoval wrote:
> textsearch_find zeroes out the offset, but the control buffer (which may or may
> not matter in this case) needs to be zeroed out as well.
> 
> Signed-off-by: Omar Sandoval <osandov@...ndov.com>
> ---
>  net/sched/em_text.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/sched/em_text.c b/net/sched/em_text.c
> index 15d353d..2a1b6d9 100644
> --- a/net/sched/em_text.c
> +++ b/net/sched/em_text.c
> @@ -36,6 +36,8 @@ static int em_text_match(struct sk_buff *skb, struct tcf_ematch *m,
>  	int from, to;
>  	struct ts_state state;
>  
> +	memset(&state, 0, sizeof(state));
> +
>  	from = tcf_get_base_ptr(skb, tm->from_layer) - skb->data;
>  	from += tm->from_offset;
>  
> -- 
> 2.1.2
> 

I forgot to mention: this patch is against 3.17.

-- 
Omar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/