linux-kernel - Re: [PATCH] bcma: Add dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141009172120.GB2410@roeck-us.net>
Date:	Thu, 9 Oct 2014 10:21:20 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Arend van Spriel <arend@...adcom.com>
Cc:	Rafał Miłecki <zajec5@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] bcma: Add dependency on OF_ADDRESS

On Thu, Oct 09, 2014 at 07:15:32PM +0200, Arend van Spriel wrote:
> On 10/09/14 18:54, Rafał Miłecki wrote:
> >On 9 October 2014 18:41, Guenter Roeck<linux@...ck-us.net>  wrote:
> >>Commit 2101e533f41a ("bcma: register bcma as device tree driver")
> >>introduces a hard dependency on OF_ADDRESS into the bcma driver.
> >>OF_ADDRESS is specifically disabled for the sparc architecture.
> >>This results in the following error when building sparc64:allmodconfig.
> 
> Does this mean on sparc (using allmodconfig) you will get CONFIG_OF
> and !CONFIG_OF_ADDRESS? Does that makes sense?
> 

You tell me. From drivers/of/Kconfig:

config OF_ADDRESS
        def_bool y
	depends on !SPARC
	select OF_ADDRESS_PCI if PCI

Presumably there is a reason to disable OF_ADDRESS for sparc.

> btw. the OF_ADDRESS dependency was introduced by commit "bcma: get
> IRQ numbers from dt".
> 
Ah, sorry. Ok, I'll send v3 after taking a break (and waiting
for additional comments).

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/