linux-kernel - Re: [PATCH] staging: rtl8188eu: coding style fixup

Open Source and information security mailing list archives

Message-ID: <20141009103818.7868983c@ygrex-lenovo>
Date:	Thu, 9 Oct 2014 10:38:18 +0400
From:	Igor Bogomazov <ygrex@...ex.ru>
To:	Denis Kirjanov <kirjanov@...il.com>
Cc:	devel@...verdev.osuosl.org, trivial@...nel.org,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	navin patidar <navin.patidar@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: rtl8188eu: coding style fixup

you are right, would be wise to do that, added

On Thu, 9 Oct 2014 10:32:37 +0400
Denis Kirjanov <kirjanov@...il.com> wrote:

> But you haven't CCed people in the CC list
> 
> On 10/9/14, Igor Bogomazov <ygrex@...ex.ru> wrote:
> > checkpatch.pl tiny fix
> > get rid of 2 warnings and 2 errors for hal/fw.c
> >
> > Signed-off-by: Igor Bogomazov <ygrex@...ex.ru>
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Cc: navin patidar <navin.patidar@...il.com>
> > Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> > ---
> > for linux-next 3.17.0
> >
> > this is an updated version of the patch I've sent two days ago, that one
> > did not apply cleanly
> >
> > diff --git a/drivers/staging/rtl8188eu/hal/fw.c
> > b/drivers/staging/rtl8188eu/hal/fw.c
> > --- a/drivers/staging/rtl8188eu/hal/fw.c
> > +++ b/drivers/staging/rtl8188eu/hal/fw.c
> > @@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)
> >  			break;
> >  	} while (counter++ < POLLING_READY_TIMEOUT_COUNT);
> >
> > -	if (counter >= POLLING_READY_TIMEOUT_COUNT) {
> > +	if (counter >= POLLING_READY_TIMEOUT_COUNT)
> >  		goto exit;
> > -	}
> >
> >  	value32 = usb_read32(adapt, REG_MCUFWDL);
> >  	value32 |= MCUFWDL_RDY;
> > @@ -193,13 +192,13 @@ int rtl88eu_download_fw(struct adapter *adapt)
> >  	u32 fwsize;
> >  	int err;
> >
> > -	if (request_firmware(&fw, fw_name, device)){
> > +	if (request_firmware(&fw, fw_name, device)) {
> >  		dev_err(device, "Firmware %s not available\n", fw_name);
> >  		return -ENOENT;
> >  	}
> >
> >  	if (fw->size > FW_8188E_SIZE) {
> > -		dev_err(device,"Firmware size exceed 0x%X. Check it.\n",
> > +		dev_err(device, "Firmware size exceed 0x%X. Check it.\n",
> >  			 FW_8188E_SIZE);
> >  		return -1;
> >  	}
> > @@ -226,7 +225,8 @@ int rtl88eu_download_fw(struct adapter *adapt)
> >  		rtl88e_firmware_selfreset(adapt);
> >  	}
> >  	_rtl88e_enable_fw_download(adapt, true);
> > -	usb_write8(adapt, REG_MCUFWDL, usb_read8(adapt, REG_MCUFWDL) |
> > FWDL_ChkSum_rpt);
> > +	usb_write8(adapt, REG_MCUFWDL,
> > +		usb_read8(adapt, REG_MCUFWDL) | FWDL_ChkSum_rpt);
> >  	_rtl88e_write_fw(adapt, pfwdata, fwsize);
> >  	_rtl88e_enable_fw_download(adapt, false);
> >
> > _______________________________________________
> > devel mailing list
> > devel@...uxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> >

-- 
Sincerely yours,

Igor Bogomazov
Saint-Petersburg, Russia

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives