linux-kernel - Re: [PATCH] staging: rtl8188eu: coding style fixup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 10 Oct 2014 14:16:09 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Igor Bogomazov <ygrex@...ex.ru>
Cc:	devel@...verdev.osuosl.org, trivial@...nel.org,
	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	navin patidar <navin.patidar@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] staging: rtl8188eu: coding style fixup

On Fri, Oct 10, 2014 at 11:09:20AM +0400, Igor Bogomazov wrote:
> checkpatch.pl tiny fix
> get rid of 2 warnings and 2 errors for hal/fw.c:
> 
> WARNING: braces {} are not necessary for single statement blocks
> WARNING: line over 80 characters
> ERROR: space required before the open brace '{'
> ERROR: space required after that ',' (ctx:VxV)
you should usually do only one type of fix in a patch.

> 
> Signed-off-by: Igor Bogomazov <ygrex@...ex.ru>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: navin patidar <navin.patidar@...il.com>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> ---
> for linux-next 3.17.0
> 
> this is an updated version of the patch I've sent yesterday, that one
> did not provide a clear description
> 
> diff --git a/drivers/staging/rtl8188eu/hal/fw.c b/drivers/staging/rtl8188eu/hal/fw.c
> --- a/drivers/staging/rtl8188eu/hal/fw.c
> +++ b/drivers/staging/rtl8188eu/hal/fw.c
> @@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)
>  			break;
>  	} while (counter++ < POLLING_READY_TIMEOUT_COUNT);
>  
> -	if (counter >= POLLING_READY_TIMEOUT_COUNT) {
> +	if (counter >= POLLING_READY_TIMEOUT_COUNT)
>  		goto exit;
> -	}
>  
>  	value32 = usb_read32(adapt, REG_MCUFWDL);
>  	value32 |= MCUFWDL_RDY;
> @@ -193,13 +192,13 @@ int rtl88eu_download_fw(struct adapter *adapt)
>  	u32 fwsize;
>  	int err;
>  
> -	if (request_firmware(&fw, fw_name, device)){
> +	if (request_firmware(&fw, fw_name, device)) {
>  		dev_err(device, "Firmware %s not available\n", fw_name);
>  		return -ENOENT;
>  	}
>  
>  	if (fw->size > FW_8188E_SIZE) {
> -		dev_err(device,"Firmware size exceed 0x%X. Check it.\n",
> +		dev_err(device, "Firmware size exceed 0x%X. Check it.\n",
>  			 FW_8188E_SIZE);

align this with the open parenthesis

>  		return -1;
>  	}
> @@ -226,7 +225,8 @@ int rtl88eu_download_fw(struct adapter *adapt)
>  		rtl88e_firmware_selfreset(adapt);
>  	}
>  	_rtl88e_enable_fw_download(adapt, true);
> -	usb_write8(adapt, REG_MCUFWDL, usb_read8(adapt, REG_MCUFWDL) | FWDL_ChkSum_rpt);
> +	usb_write8(adapt, REG_MCUFWDL,
> +		usb_read8(adapt, REG_MCUFWDL) | FWDL_ChkSum_rpt);
same here also. 
check your patch with --strict option of checkpatch

thanks
sudip

>  	_rtl88e_write_fw(adapt, pfwdata, fwsize);
>  	_rtl88e_enable_fw_download(adapt, false);
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/