linux-kernel - Re: [PATCH] bcma: Add dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5437A737.2030509@broadcom.com>
Date:	Fri, 10 Oct 2014 11:30:31 +0200
From:	Arend van Spriel <arend@...adcom.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
CC:	Guenter Roeck <linux@...ck-us.net>,
	Rafał Miłecki <zajec5@...il.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] bcma: Add dependency on OF_ADDRESS

On 10/09/14 23:48, Hauke Mehrtens wrote:
> On 10/09/2014 09:25 PM, Guenter Roeck wrote:
>> On Thu, Oct 09, 2014 at 08:28:31PM +0200, Hauke Mehrtens wrote:
>>> On 10/09/2014 07:29 PM, Guenter Roeck wrote:
>>>> On Thu, Oct 09, 2014 at 07:18:31PM +0200, Arend van Spriel wrote:
>>>>> On 10/09/14 19:15, Arend van Spriel wrote:
>>>>>> On 10/09/14 18:54, Rafał Miłecki wrote:
>>>>>>> On 9 October 2014 18:41, Guenter Roeck<linux@...ck-us.net>  wrote:
>>>>>>>> Commit 2101e533f41a ("bcma: register bcma as device tree driver")
>>>>>>>> introduces a hard dependency on OF_ADDRESS into the bcma driver.
>>>>>>>> OF_ADDRESS is specifically disabled for the sparc architecture.
>>>>>>>> This results in the following error when building sparc64:allmodconfig.
>>>>>>
>>>>>> Does this mean on sparc (using allmodconfig) you will get CONFIG_OF and
>>>>>> !CONFIG_OF_ADDRESS? Does that makes sense?
>>>>>
>>>>> Is CONFIG_OF is used on sparc to access OpenBoot information?
>>>>>
>>>> I have no idea. All I know is that the driver doesn't build anymore with OF
>>>> enabled and OF_ADDRESS disabled.
>>>
>>> Device tree support in bcma is only needed on some SoC, when this is
>>> used on a PCIe card it is not needed.
>>>
>>> I would just deactivate the parts that are using device tree in bcma
>>> when it is not available. I will send a patch after having something to eat.
>>>
>> Devicetree dependency is already covered with #ifdef CONFIG_OF. Problem is
>> that it really needs #ifdef CONFIG_OF_ADDRESS. Though even that might be
>> better than my patch, since it would at least build the driver on sparc
>> as it used to do.
>>
>>> Is there a better method which is compatible with SPARC than using
>>> of_translate_address() to get the reg address and also take the ranges
>>> attribute of the bus into account?
>>>
>> No idea, sorry. Can you by any chance use pcie device information
>> instead of depending on devicetree data ?
>
> Device tree is not used for PCIe devices in bcma. We only use it when
> bcma is used for the system bus on some Broadcom SoCs, currently there
> is no plan to use device tree for PCIe devices in bcma. I think bcma is
> only used on wifi cards connected via PCIe on Sparc systems.

When we mainlined I verified the brcmsmac was working on a sparc system. 
However, at that time we were not using BCMA. I do not recall whether or 
not we tested on sparc with BCMA support. I might give it a spin again.

Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/