linux-kernel - Re: [PATCH] smaps should deal with huge zero page exactly same as normal zero page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5437EEA3.50705@intel.com>
Date:	Fri, 10 Oct 2014 07:35:15 -0700
From:	Dave Hansen <dave.hansen@...el.com>
To:	Fengwei Yin <yfw.kernel@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	fengguang.wu@...el.com,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCH] smaps should deal with huge zero page exactly same as
 normal zero page

On 10/10/2014 06:21 AM, Fengwei Yin wrote:
> @@ -787,6 +788,9 @@ check_pfn:
>  		return NULL;
>  	}
>  
> +	if (is_huge_zero_pfn(pfn))
> +		return NULL;
> +

That looks a lot better.  One thing, why not put the is_huge_zero_pfn()
check next to the is_zero_pfn() check?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/