linux-kernel - Re: [GIT PULL] MFD for v3.18

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Oct 2014 18:44:04 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] MFD for v3.18

Hi,

On Sat, Oct 11, 2014 at 07:01:09AM -0400, Linus Torvalds wrote:
> On Fri, Oct 10, 2014 at 5:40 AM, Lee Jones <lee.jones@...aro.org> wrote:
> >  The following changes since commit 52addcf9d6669fa439387610bc65c92fa0980cef:
> >
> >   Linux 3.17-rc2 (2014-08-25 15:36:20 -0700)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-for-linus-3.18
> 
> This causes Kconfig problems for me when doing "make allmodconfig":
> 
>   fs/sysfs/Kconfig:1: symbol SYSFS is selected by CHARGER_MAX14577
>   drivers/power/Kconfig:327: symbol CHARGER_MAX14577 depends on POWER_SUPPLY
>   drivers/power/Kconfig:1: symbol POWER_SUPPLY is selected by HID_SONY
>   drivers/hid/Kconfig:649: symbol HID_SONY depends on NEW_LEDS
>   drivers/leds/Kconfig:8: symbol NEW_LEDS is selected by SENSORS_APPLESMC
>   drivers/hwmon/Kconfig:299: symbol SENSORS_APPLESMC depends on HWMON
>   drivers/hwmon/Kconfig:5: symbol HWMON is selected by EEEPC_LAPTOP
>   drivers/platform/x86/Kconfig:496: symbol EEEPC_LAPTOP depends on HOTPLUG_PCI
>   drivers/pci/hotplug/Kconfig:5: symbol HOTPLUG_PCI depends on SYSFS
> 
> and the reason seems to be your changes to drivers/power/Kconfig for
> the CHARGER_MAX14577 symbol.
> 
> So I pulled and then unpulled.  I realize you're not the only guilty
> party in this chain, but your pull is the final drop, so.. I would
> suggest making that MAX14577 charger interface _depend_ on SYSFS, not
> try to select it.

This is fixed in battery-2.6.git. I will send a pull request in a
couple of minutes.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)