linux-kernel - Re: [PATCH] char: misc: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413052541.22149.10.camel@joe-AO725>
Date:	Sat, 11 Oct 2014 11:35:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rahul Bedarkar <rahulbedarkar89@...il.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char: misc: use pr_err instead of printk

On Sun, 2014-10-12 at 00:01 +0530, Rahul Bedarkar wrote:
[]
> diff --git a/drivers/char/misc.c b/drivers/char/misc.c
[]
> @@ -280,12 +280,12 @@ static int __init misc_init(void)
>  
>  	err = -EIO;
>  	if (register_chrdev(MISC_MAJOR,"misc",&misc_fops))
> -		goto fail_printk;
> +		goto fail_pr_err;
>  	misc_class->devnode = misc_devnode;
>  	return 0;
>  
> -fail_printk:
> -	printk("unable to get major %d for misc devices\n", MISC_MAJOR);
> +fail_pr_err:
> +	pr_err("unable to get major %d for misc devices\n", MISC_MAJOR);
>  	class_destroy(misc_class);
>  fail_remove:
>  	remove_proc_entry("misc", NULL);

The printk is not relevant.
Maybe the label should be "fail_destroy:"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/