linux-kernel - Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Oct 2014 14:39:03 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Raymond Yau <superquad.vortex2@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with
 dev_*

On Sat, Oct 11, 2014 at 03:20:56PM +0800, Raymond Yau wrote:
> >
> > pr_* macros replaced with dev_* as they are more preffered over pr_*.
> > each file which had pr_* was reviewed manually and replaced with dev_*.
> > here we have actually used the reference of the vortex which was added
> > to some functions in the previous patch of this series.
> >
> > The prefix of the CARD_NAME and prefix of "vortex:" was also
> > removed as the dev_* will print the device name.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> > ---
> >
> 
> >  static int vortex_core_init(vortex_t *vortex)
> >  {
> >
> > -       pr_info( "Vortex: init.... ");
> > +       dev_info(vortex->card->dev, "init.... ");
> 
> Is it possible to add linefeed  since "done/n" won't appear in the same
> line with init nor shutdown?
> 
should we add linefeed ?
as of now it will print init.... then it will print done as the init is complete.
so dmesg will show us:

init....done.

same for shutdown.
but if we give linefeed , then it will become : 

init....
done.

the meaning will be lost. and many user might just wonder what is done ? 

thanks
sudip

> >         /* Hardware Init. */
> >         hwwrite(vortex->mmio, VORTEX_CTRL, 0xffffffff);
> >         msleep(5);
> > @@ -2729,7 +2735,7 @@ static int vortex_core_init(vortex_t *vortex)
> >         //vortex_enable_timer_int(vortex);
> >         //vortex_disable_timer_int(vortex);
> >
> > -       pr_info( "done.\n");
> > +       dev_info(vortex->card->dev, "done.\n");
> >         spin_lock_init(&vortex->lock);
> >
> >         return 0;
> > @@ -2738,7 +2744,7 @@ static int vortex_core_init(vortex_t *vortex)
> >  static int vortex_core_shutdown(vortex_t * vortex)
> >  {
> >
> > -       pr_info( "Vortex: shutdown...");
> > +       dev_info(vortex->card->dev, "shutdown...");
> >  #ifndef CHIP_AU8820
> >         vortex_eq_free(vortex);
> >         vortex_Vort3D_disable(vortex);
> > @@ -2760,7 +2766,7 @@ static int vortex_core_shutdown(vortex_t * vortex)
> >         msleep(5);
> >         hwwrite(vortex->mmio, VORTEX_IRQ_SOURCE, 0xffff);
> >
> > -       pr_info( "done.\n");
> > +       dev_info(vortex->card->dev, "done.\n");
> >         return 0;
> >  }
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/