linux-kernel - Re: [PATCH] um: always use the same type for __syscall_stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Oct 2014 14:24:33 +0200
From:	Richard Weinberger <richard@....at>
To:	Nicolas Iooss <nicolas.iooss_linux@....org>,
	Jeff Dike <jdike@...toit.com>,
	user-mode-linux-devel@...ts.sourceforge.net,
	user-mode-linux-user@...ts.sourceforge.net
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: always use the same type for __syscall_stub_start

Am 11.10.2014 um 14:15 schrieb Nicolas Iooss:
> 2014-10-11 13:42 GMT+02:00 Richard Weinberger:
>> Am 11.10.2014 um 13:29 schrieb Nicolas Iooss:
>>> syscall_stub_start is declared with different types in C files:
>>>
>>>   arch/um/kernel/physmem.c: extern int __syscall_stub_start;
>>>   arch/um/kernel/skas/mmu.c: extern int __syscall_stub_start;
>>>   arch/um/os-Linux/skas/mem.c: extern unsigned long __syscall_stub_start;
>>>   arch/um/os-Linux/skas/process.c: extern int __syscall_stub_start;
>>>
>>> Fix this inconsistency by always using unsigned long.  This does not
>>> change anything in the compiled code because only the address of
>>> __syscall_stub_start is used, but it makes the static checker I use
>>> stop complaining about incompatible declarations.
>>
>> While we're here, can you put these declarations into a single header
> file?
> 
> Sure.  Do you have a specific header file in mind or shall I create
> arch/um/include/asm/sections.h with declarations for
> __syscall_stub_start, __syscall_stub_end and __binary_start (used in
> arch/um/kernel/um_arch.c)?

Not really. Maybe you can find a common header for all.
But I fear where is a reason why these declarations are not in a
common header. They are used in the kernel- and userspace part of
UML.
Anyway, please give it a try. :)

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/