linux-kernel - Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141012170332.GA16885@infradead.org>
Date:	Sun, 12 Oct 2014 10:03:32 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Eric Biggers <ebiggers3@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfs: Deduplicate code shared by xattr system calls
 operating on paths

On Sun, Oct 12, 2014 at 11:59:58AM -0500, Eric Biggers wrote:
> The following pairs of system calls dealing with extended attributes only
> differ in their behavior on whether the symbolic link is followed (when
> the named file is a symbolic link):
> 
> - setxattr() and lsetxattr()
> - getxattr() and lgetxattr()
> - listxattr() and llistxattr()
> - removexattr() and lremovexattr()
> 
> Despite this, the implementations all had duplicated code, so this commit
> redirects each of the above pairs of system calls to a corresponding
> function to which different lookup flags (LOOKUP_FOLLOW or 0) are passed.
> 
> For me this reduced the stripped size of xattr.o from 8824 to 8248 bytes.

Looks good,

Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/