| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <EF2BF2D8-F612-4812-AF96-05944AE0200C@zytor.com> Date: Sun, 12 Oct 2014 10:13:33 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Chuck Ebbert <cebbert.lkml@...il.com> CC: Ingo Molnar <mingo@...hat.com>, Thomas Gleixner <tglx@...utronix.de>, x86@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] x86: Clean up stack access code in irq_32.c That's not a justification for change. Claiming no harm is nevessary but not sufficient. On October 12, 2014 9:53:32 AM PDT, Chuck Ebbert <cebbert.lkml@...il.com> wrote: >On Sun, 12 Oct 2014 09:47:53 -0700 >"H. Peter Anvin" <hpa@...or.com> wrote: > >[replying to the list this time, sigh] > >> We changed this to asm because the C broke some compilers. Why are >you changing it back? >> > >The C broke some compilers because it was using a global register >variable. This is a local one, which the clang documentation says is >supported. And I compiled it with clang with no problem. > >> On October 12, 2014 9:43:53 AM PDT, Chuck Ebbert ><cebbert.lkml@...il.com> wrote: >> >Use C instead of asm for accessing the stack pointer. And define >some >> >macros to make the code easier to understand. >> > -- Sent from my mobile phone. Please pardon brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists