lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 12 Oct 2014 22:07:13 +0100
From:	Al Viro <>
To:	Eric Biggers <>
Subject: Re: [PATCH 2/5] fs/anon_inodes.c: Simplify control flow in

On Sun, Oct 12, 2014 at 03:42:39PM -0500, Eric Biggers wrote:

>  	file = anon_inode_getfile(name, fops, priv, flags);
>  	if (IS_ERR(file)) {
> -		error = PTR_ERR(file);
> -		goto err_put_unused_fd;
> +		put_unused_fd(fd);
> +		return PTR_ERR(file);
>  	}
>  	fd_install(fd, file);

at least slap unlikely() on that if (IS_ERR(...))...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists