linux-kernel - RE: [PATCH v2 3/4] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <00f301cfe6a3$78e90ab0$6abb2010$%tikhomirov@samsung.com>
Date:	Mon, 13 Oct 2014 14:06:39 +0900
From:	Anton Tikhomirov <av.tikhomirov@...sung.com>
To:	'Vivek Gautam' <gautam.vivek@...sung.com>,
	linux-usb@...r.kernel.org
Cc:	linux-samsung-soc@...r.kernel.org, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, balbi@...com, kgene.kim@...sung.com,
	mark.rutland@....com, pawel.moll@....com, robh+dt@...nel.org,
	kishon@...com
Subject: RE: [PATCH v2 3/4] phy: exynos5-usbdrd: Add facility for VBUS-BOOST-5V
 supply

Hi Vivek,

> Some Exynos SoCs have a separate regulator controlling a

I guess you meant the Exynos based *boards* instead of SoCs,
since Exynos SoCs don't have any boost regulators.

> Boost 5V supply which goes as input for VBUS regulator.
> So adding a control for the same in driver, to enable
> vbus supply on the port.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> ---
>  drivers/phy/phy-exynos5-usbdrd.c |   30 ++++++++++++++++++++++++++++--
>  1 file changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-
> exynos5-usbdrd.c
> index 013ee84..57e8a0a 100644
> --- a/drivers/phy/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/phy-exynos5-usbdrd.c
> @@ -176,6 +176,7 @@ struct exynos5_usbdrd_phy {
>  	u32 extrefclk;
>  	struct clk *ref_clk;
>  	struct regulator *vbus;
> +	struct regulator *vbus_boost;
>  };
> 
>  static inline
> @@ -455,11 +456,20 @@ static int exynos5_usbdrd_phy_power_on(struct phy
> *phy)
>  	clk_prepare_enable(phy_drd->ref_clk);
> 
>  	/* Enable VBUS supply */
> +	if (phy_drd->vbus_boost) {
> +		ret = regulator_enable(phy_drd->vbus_boost);
> +		if (ret) {
> +			dev_err(phy_drd->dev,
> +				"Failed to enable VBUS boost supply\n");
> +			goto fail_vbus;
> +		}
> +	}
> +
>  	if (phy_drd->vbus) {
>  		ret = regulator_enable(phy_drd->vbus);
>  		if (ret) {
>  			dev_err(phy_drd->dev, "Failed to enable VBUS
> supply\n");
> -			goto fail_vbus;
> +			goto fail_vbus_boost;
>  		}
>  	}
> 
> @@ -468,6 +478,10 @@ static int exynos5_usbdrd_phy_power_on(struct phy
> *phy)
> 
>  	return 0;
> 
> +fail_vbus_boost:
> +	if (phy_drd->vbus_boost)
> +		regulator_disable(phy_drd->vbus_boost);
> +
>  fail_vbus:
>  	clk_disable_unprepare(phy_drd->ref_clk);
>  	clk_disable_unprepare(phy_drd->pipeclk);
> @@ -489,6 +503,8 @@ static int exynos5_usbdrd_phy_power_off(struct phy
> *phy)
>  	/* Disable VBUS supply */
>  	if (phy_drd->vbus)
>  		regulator_disable(phy_drd->vbus);
> +	if (phy_drd->vbus_boost)
> +		regulator_disable(phy_drd->vbus_boost);
> 
>  	clk_disable_unprepare(phy_drd->ref_clk);
>  	clk_disable_unprepare(phy_drd->pipeclk);
> @@ -644,7 +660,7 @@ static int exynos5_usbdrd_phy_probe(struct
> platform_device *pdev)
>  		break;
>  	}
> 
> -	/* Get Vbus regulator */
> +	/* Get Vbus regulators */
>  	phy_drd->vbus = devm_regulator_get(dev, "vbus");
>  	if (IS_ERR(phy_drd->vbus)) {
>  		ret = PTR_ERR(phy_drd->vbus);
> @@ -655,6 +671,16 @@ static int exynos5_usbdrd_phy_probe(struct
> platform_device *pdev)
>  		phy_drd->vbus = NULL;
>  	}
> 
> +	phy_drd->vbus_boost = devm_regulator_get(dev, "vbus-boost");
> +	if (IS_ERR(phy_drd->vbus_boost)) {
> +		ret = PTR_ERR(phy_drd->vbus_boost);
> +		if (ret == -EPROBE_DEFER)
> +			return ret;
> +
> +		dev_warn(dev, "Failed to get VBUS boost supply
> regulator\n");
> +		phy_drd->vbus_boost = NULL;
> +	}
> +
>  	dev_vdbg(dev, "Creating usbdrd_phy phy\n");
> 
>  	for (i = 0; i < EXYNOS5_DRDPHYS_NUM; i++) {
> --
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/