linux-kernel - Re: [PATCH] modules, lock around setting of MODULE_STATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87egucedbt.fsf@rustcorp.com.au>
Date:	Mon, 13 Oct 2014 16:11:26 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Oleg Nesterov <oleg@...hat.com>,
	Prarit Bhargava <prarit@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modules, lock around setting of MODULE_STATE_UNFORMED

Oleg Nesterov <oleg@...hat.com> writes:
> On 10/08, Prarit Bhargava wrote:
>>
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -1842,7 +1842,9 @@ static void free_module(struct module *mod)
>>  
>>  	/* We leave it in list to prevent duplicate loads, but make sure
>>  	 * that noone uses it while it's being deconstructed. */
>> +	mutex_lock(&module_mutex);
>>  	mod->state = MODULE_STATE_UNFORMED;
>> +	mutex_unlock(&module_mutex);
>>  
>>  	/* Remove dynamic debug info */
>>  	ddebug_remove_module(mod->name);
>
> Reviewed-by: Oleg Nesterov <oleg@...hat.com>

Thanks, good catch.

I've cc'd stable too.

Cheers,
Rusty.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/