lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Oct 2014 11:46:02 +0200 From: Daniel Borkmann <dborkman@...hat.com> To: Lubomir Rintel <lkundrak@...sk> CC: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Hannes Frederic Sowa <hannes@...essinduktion.org> Subject: Re: [PATCH] ipv6: notify userspace when we added or changed an ipv6 token On 10/10/2014 04:08 PM, Lubomir Rintel wrote: > NetworkManager might want to know that it changed when the router advertisement > arrives. > > Signed-off-by: Lubomir Rintel <lkundrak@...sk> > Cc: Hannes Frederic Sowa <hannes@...essinduktion.org> > Cc: Daniel Borkmann <dborkman@...hat.com> > --- > net/ipv6/addrconf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > index 3e118df..3d11390 100644 > --- a/net/ipv6/addrconf.c > +++ b/net/ipv6/addrconf.c > @@ -4528,6 +4528,7 @@ static int inet6_set_iftoken(struct inet6_dev *idev, struct in6_addr *token) > } > > write_unlock_bh(&idev->lock); > + netdev_state_change(dev); I'm wondering why netdev_state_change()? You are probably only after the netlink notification that is being invoked, i.e. rtmsg_ifinfo(RTM_NEWLINK, ...), and don't strictly want to call the device notifier chain. Perhaps it might be better to define a new RTM_SETTOKEN, and just call inet6_ifinfo_notify(RTM_SETTOKEN, idev) as this is only idev specific anyway? > addrconf_verify_rtnl(); > return 0; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists