linux-kernel - Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible string for device binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141013103512.GJ27755@sirena.org.uk>
Date:	Mon, 13 Oct 2014 12:35:12 +0200
From:	Mark Brown <broonie@...nel.org>
To:	Gyungoh Yoo <gyungoh@...il.com>
Cc:	sameo@...ux.intel.com, lee.jones@...aro.org, jg1.han@...sung.com,
	cooloney@...il.com, lgirdwood@...il.com, jack.yoo@...worksinc.com,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	grant.likely@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	pawel.moll@....com, heiko@...ech.de, jason@...edaemon.net,
	shawn.guo@...escale.com, treding@...dia.com,
	florian.vaussard@...l.ch, trivial@...nel.org, linux@...ck-us.net,
	andrew@...n.ch, jic23@...nel.org
Subject: Re: [RESUBMIT PATCH v4 7/8] regulator: sky81452: Add compatible
 string for device binding

On Mon, Oct 13, 2014 at 02:47:41PM +0900, Gyungoh Yoo wrote:

> -	np = of_get_child_by_name(dev->parent->of_node, "regulator");
> -	if (unlikely(!np)) {
> +	if (!np) {
>  		dev_err(dev, "regulator node not found");
> -		return NULL;
> +		return ERR_PTR(-ENODATA);
>  	}

If you're doing anything here you should convert the code to use the
simplified interface for parsing regulator data based on putting the
subnode name and regualtor name in the regulator descriptor.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)