linux-kernel - Re: [PATCH RESEND] regulator: Add stub for devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141013110426.GR27755@sirena.org.uk>
Date:	Mon, 13 Oct 2014 13:04:26 +0200
From:	Mark Brown <broonie@...nel.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Airlie <airlied@...ux.ie>,
	Rob Clark <robdclark@...il.com>,
	David Brown <davidb@...eaurora.org>,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH RESEND] regulator: Add stub for
 devm_regulator_get_exclusive

On Thu, Oct 09, 2014 at 07:14:18PM +0800, Axel Lin wrote:
> Also makes regulator_get_exclusive and devm_regulator_get_exclusive stub
> functions return error pointer.
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> Hi Mark,
> I hit below build error and then found this patch is still not yet upstream.
> So here is a resend.
> 
>   CC [M]  drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.o
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c: In function 'mdp4_kms_init':
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:2: error: implicit declaration of function 'devm_regulator_get_exclusive' [-Werror=implicit-function-declaration]
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c:384:16: error: assignment makes pointer from integer without a cast [-Werror]

To be honest the fact that you're hitting bugs with this is kind of
making me think that this is a good idea.  

Looking at the code in the driver there are rather a lot of problems -
the whole way the errors are ignored in the probe function is concerning
and most likely buggy at least with deferred probe. For the immediate
problem with using regulator_get_exclusive() I can't understand why it's
being used at all.  In general all the regulator usage in the driver is
atypical and doesn't look idiomatic - do we understand what's going on
here?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)