linux-kernel - Re: [PATCH] staging: lustre: lustre: ptlrpc: sec.c: Replacing strncat with strlcat to avoid overwrite size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <543BE40F.1050509@gmail.com>
Date:	Mon, 13 Oct 2014 22:39:11 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Oleg Drokin <oleg.drokin@...el.com>
CC:	Andreas Dilger <andreas.dilger@...el.com>,
	Andriy Skulysh <Andriy_Skulysh@...atex.com>,
	Liang Zhen <liang.zhen@...el.com>,
	Denis Pithon <denis.pithon@...il.com>,
	Patrick Farrell <paf@...y.com>,
	Masanari Iida <standby24x7@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: lustre: ptlrpc: sec.c:  Replacing strncat
 with strlcat to avoid overwrite size

On 10/12/14 23:55, Rickard Strandqvist wrote:
> Changed from using strncat with strlcat to avoid overwrite the max size.
> Take the opportunity to change a snprint to strlcpy.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/sec.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/sec.c b/drivers/staging/lustre/lustre/ptlrpc/sec.c
> index 5cff7ee..d276e98 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/sec.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/sec.c
> @@ -209,7 +209,7 @@ EXPORT_SYMBOL(sptlrpc_flavor2name_bulk);
>  
>  char *sptlrpc_flavor2name(struct sptlrpc_flavor *sf, char *buf, int bufsize)
>  {
> -	snprintf(buf, bufsize, "%s", sptlrpc_flavor2name_base(sf->sf_rpc));
> +	strlcpy(buf, sptlrpc_flavor2name_base(sf->sf_rpc), bufsize);
>  
>  	/*
>  	 * currently we don't support customized bulk specification for
> @@ -220,10 +220,9 @@ char *sptlrpc_flavor2name(struct sptlrpc_flavor *sf, char *buf, int bufsize)
>  
>  		bspec[0] = '-';
>  		sptlrpc_flavor2name_bulk(sf, &bspec[1], sizeof(bspec) - 1);
> -		strncat(buf, bspec, bufsize);
> +		strlcat(buf, bspec, bufsize);
>  	}
>  
> -	buf[bufsize - 1] = '\0';
>  	return buf;
>  }
>  EXPORT_SYMBOL(sptlrpc_flavor2name);
> 

At least for me, it is OK.

Acked-by: Chen Gang <gang.chen.5i5j@...il.com>

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/