linux-kernel - Re: [PATCH 08/97] mm, thp: do not allow thp faults to avoid cpuset restrictions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141013151727.GB23874@suse.de>
Date:	Mon, 13 Oct 2014 16:17:27 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Linux-Stable <stable@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/97] mm, thp: do not allow thp faults to avoid cpuset
 restrictions

On Fri, Sep 26, 2014 at 11:53:14AM +0200, Jiri Slaby wrote:
> On 08/28/2014, 08:34 PM, Mel Gorman wrote:
> > From: David Rientjes <rientjes@...gle.com>
> > 
> > commit b104a35d32025ca740539db2808aa3385d0f30eb upstream.
> > 
> > The page allocator relies on __GFP_WAIT to determine if ALLOC_CPUSET
> > should be set in allocflags.  ALLOC_CPUSET controls if a page allocation
> > should be restricted only to the set of allowed cpuset mems.
> > 
> > Transparent hugepages clears __GFP_WAIT when defrag is disabled to prevent
> > the fault path from using memory compaction or direct reclaim.  Thus, it
> > is unfairly able to allocate outside of its cpuset mems restriction as a
> > side-effect.
> > 
> > This patch ensures that ALLOC_CPUSET is only cleared when the gfp mask is
> > truly GFP_ATOMIC by verifying it is also not a thp allocation.
> 
> Hi, the time has come to apply this series. Thanks a lot for doing that.
> 

Thanks for picking them up!

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/