lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Oct 2014 09:11:20 -0700 From: Doug Anderson <dianders@...omium.org> To: Caesar Wang <caesar.wang@...k-chips.com> Cc: Heiko Stübner <heiko@...ech.de>, Zhang Rui <rui.zhang@...el.com>, Eduardo Valentin <edubezval@...il.com>, Arnd Bergmann <arnd@...db.de>, zyf <zyf@...k-chips.com>, linux-rockchip@...ts.infradead.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, Eddie Cai <cf@...k-chips.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Derek Basehore <dbasehore@...omium.org>, Tao Huang <huangtao@...k-chips.com>, 陈渐飞 <cjf@...k-chips.com>, Shunqian Zheng <zhengsq@...k-chips.com> Subject: Re: [PATCH v9 1/5] thermal: rockchip: add driver for thermal Caesar, On Sat, Oct 11, 2014 at 12:29 AM, Caesar Wang <caesar.wang@...k-chips.com> wrote: > +static void rk_tsadcv2_initialize(int reset_mode, int chn, void __iomem *regs, > + unsigned long hw_shut_temp) > +{ > + u32 shutdown_value; > + > + shutdown_value = rk_tsadcv2_temp_to_code(hw_shut_temp); > + > + /* Enable measurements at ~ 10 Hz */ > + writel_relaxed(0 | TSADCV2_AUTO_TSHUT_POLARITY_HIGH, regs + > + TSADCV2_AUTO_CON); > + writel_relaxed(TSADCV2_AUTO_PERIOD_TIME, regs + TSADCV2_AUTO_PERIOD); > + writel_relaxed(TSADCV2_AUTO_PERIOD_HT_TIME, regs + > + TSADCV2_AUTO_PERIOD_HT); > + writel_relaxed(shutdown_value, regs + TSADCV2_COMP_SHUT(chn)); > + writel_relaxed(TSADCV2_HIGHT_INT_DEBOUNCE_TIME, regs + > + TSADCV2_HIGHT_INT_DEBOUNCE); > + writel_relaxed(TSADCV2_HIGHT_TSHUT_DEBOUNCE_TIME, regs + > + TSADCV2_HIGHT_TSHUT_DEBOUNCE); > + > + if (reset_mode == GPIO) > + writel_relaxed(TSADCV2_SHUT_2GPIO_SRC_EN(chn) | > + TSADCV2_INT_SRC_EN(chn), regs + > + TSADCV2_INT_EN); > + else > + writel_relaxed(TSADCV2_SHUT_2CRU_SRC_EN(chn) | > + TSADCV2_INT_SRC_EN(chn) , regs + > + TSADCV2_INT_EN); > + > + writel_relaxed(TSADCV2_AUTO_SRC_EN(chn) | TSADCV2_AUTO_EN, regs + > + TSADCV2_AUTO_CON); Aren't you clobbering the polarity here? NOTE: I didn't do a full review of this driver, just noticed that while looking at another patch and figure'd I'd respond here, too. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists