linux-kernel - Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPybu_316A6DZ7MOFm=6vHw2vfS+6_CnZD5J4wVJkbRa1Ycnuw@mail.gmail.com>
Date:	Mon, 13 Oct 2014 21:02:57 +0200
From:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-serial@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

Hello Alan

>> +     spin_unlock_irqrestore(&port->lock, flags);
>
> Looks good apart from this bit.. The copy needs to go to a temporary
> before the lock is taken otherwise we may sleep on a pagefault with irqs
> off
>
> Alan

Good catch

I will fix it as you suggest.

I will give a give a couple of days for comments about the serie
"[PATCH 00/12] Handle TIOC[GS]RS485
iocts on serial_core"  Then I will resend the series including this
patch (of course, fixed)


Thanks!


-- 
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/