linux-kernel - Re: [PATCH] staging: wlan-ng: Renamed prism2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Oct 2014 13:32:27 -0600
From:	Erich Cordoba <erich.cordoba@...dex.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>
Subject: Re: [PATCH] staging: wlan-ng: Renamed prism2_fragmenthreshold in prism2mib.c

The idea was to reduce the length of the line (to 80 characters) by renaming this function. 
But, now reviewing the result I can see that the name of the function has lost meaning. 
Please ignore this patch. 

-Erich

12.10.2014, 21:28, "Greg KH" <gregkh@...uxfoundation.org>:
> On Sun, Oct 12, 2014 at 09:29:32PM -0500, Erich Cordoba Malibran wrote:
>>  From: Erich Cordoba Malibran <erich.cordoba@...dex.com>
>>
>>  Renamed function to fix style issues.
>
> Why is changing a name, to a misspelled one, a "style issue fix"?
>>  Signed-off-by: Erich Cordoba Malibran <erich.cordoba@...dex.com>
>>  ---
>>   drivers/staging/wlan-ng/prism2mib.c | 26 +++++++++++++-------------
>>   1 file changed, 13 insertions(+), 13 deletions(-)
>>
>>  diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
>>  index 0163e06..30d224f 100644
>>  --- a/drivers/staging/wlan-ng/prism2mib.c
>>  +++ b/drivers/staging/wlan-ng/prism2mib.c
>>  @@ -132,12 +132,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
>>                                           struct p80211msg_dot11req_mibset *msg,
>>                                           void *data);
>>
>>  -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
>>  -    int isget,
>>  -    wlandevice_t *wlandev,
>>  -    hfa384x_t *hw,
>>  -    struct p80211msg_dot11req_mibset *msg,
>>  -    void *data);
>>  +static int prism2mib_fragmenthreshold(struct mibrec *mib,
>>  +      int isget,
>>  +      wlandevice_t *wlandev,
>>  +      hfa384x_t *hw,
>>  +      struct p80211msg_dot11req_mibset *msg,
>>  +      void *data);
>>
>>   static int prism2mib_priv(struct mibrec *mib,
>>                             int isget,
>>  @@ -198,7 +198,7 @@ static struct mibrec mibtab[] = {
>>           {DIDmib_dot11mac_dot11OperationTable_dot11FragmentationThreshold,
>>            F_STA | F_READ | F_WRITE,
>>            HFA384x_RID_FRAGTHRESH, 0, 0,
>>  - prism2mib_fragmentationthreshold},
>>  + prism2mib_fragmenthreshold},
>>           {DIDmib_dot11mac_dot11OperationTable_dot11MaxTransmitMSDULifetime,
>>            F_STA | F_READ,
>>            HFA384x_RID_MAXTXLIFETIME, 0, 0,
>>  @@ -660,12 +660,12 @@ static int prism2mib_excludeunencrypted(struct mibrec *mib,
>>   *
>>   ----------------------------------------------------------------*/
>>
>>  -static int prism2mib_fragmentationthreshold(struct mibrec *mib,
>>  -    int isget,
>>  -    wlandevice_t *wlandev,
>>  -    hfa384x_t *hw,
>>  -    struct p80211msg_dot11req_mibset *msg,
>>  -    void *data)
>>  +static int prism2mib_fragmenthreshold(struct mibrec *mib,
>>  +      int isget,
>>  +      wlandevice_t *wlandev,
>>  +      hfa384x_t *hw,
>>  +      struct p80211msg_dot11req_mibset *msg,
>>  +      void *data)
>>   {
>>           int result;
>>           u32 *uint32 = (u32 *) data;
>>  --
>>  2.1.2
>
> I don't understand the problem you are trying to solve here, what is it?
>
> confused,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/