linux-kernel - Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHb8M2DZOrwHTUvbgAa8Ld2P=Dw9LpnZcsusvbgwjabUeqg2Sg@mail.gmail.com>
Date:	Tue, 14 Oct 2014 08:44:05 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Lidza Louina <lidza.louina@...il.com>,
	Mark Hounschell <markh@...pro.net>,
	devel <devel@...verdev.osuosl.org>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] staging: dgap: re-arrange functions for removing forward declarations.

Hi,

2014-10-13 23:56 GMT+09:00 Joe Perches <joe@...ches.com>:
> On Mon, 2014-10-13 at 17:01 +0900, DaeSeok Youn wrote:
>> Hi,
>>
>> 2014-10-13 12:25 GMT+09:00 Greg KH <gregkh@...uxfoundation.org>:
>> > On Mon, Oct 13, 2014 at 11:34:25AM +0900, Daeseok Youn wrote:
>> >> Re-arrange the functions for removing forward declarations.
>> >>
>> >> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>> >> ---
>> >> This patch has too many changes for re-arranging the functions.
>> >> So I wonder that I should break this up into smaller patches.
>> >
>> > Are the .o files identical before and after this patch?  If so, it's
>> > fine.
>> Ok. I will check for that.
>
> The .o files shouldn't be identical after function reordering.
>
Is it possible to sort "objdump -d" output by function name?
I'm not sure but it can be checked after sorting.

I think greg want to know missing functions in this patch because this
has many changes.

thanks.

regards,
Daeseok Youn.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/