| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Oct 2014 14:31:24 +0530 From: Kiran Padwal <kiran.padwal@...rtplayin.com> To: Mark Brown <broonie@...nel.org> CC: linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH 3/3] spi: qup: Remove .owner field for driver On Tuesday 14 October 2014 01:39 PM, Mark Brown wrote: > On Tue, Oct 14, 2014 at 11:47:57AM +0530, Kiran Padwal wrote: >> On Monday 13 October 2014 06:39 PM, Mark Brown wrote: > >>> Two problems: >>> - I'm missing patches 1 and 2. > >> These patches are same like this one, >> [1] https://lkml.org/lkml/2014/10/9/58 >> [2] https://lkml.org/lkml/2014/10/9/52 > > You should at least be sending the cover letter to everyone so that they > know what's going on. OK, I will take care of this next time. > >>> - This only changes one driver but essentially every SPI driver >>> initializes .owner - why is only thi sone driver being changed? > >> Nothing more intention, but just remove superfluous .owner field for drivers which >> use the module_platform_driver API, as this is overridden in >> platform_driver_register anyway. > > My point is that doing a change like this to random drivers isn't great, > if you're going to do this sort of thing it is better to do it for > everything rather than making things inconsistent. > Sure, I will do that. Thanks, --Kiran -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists