linux-kernel - Re: [PATCH] serial: 8250_core: use pre-decrement for iteration limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141014115234.GB15616@ci00147.xsens-tech.local>
Date:	Tue, 14 Oct 2014 13:52:34 +0200
From:	Frans Klaver <frans.klaver@...ns.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	Jiri Slaby <jslaby@...e.cz>, <linux-serial@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_core: use pre-decrement for iteration limit

On Mon, Oct 13, 2014 at 05:09:11PM +0200, Frans Klaver wrote:
> In serial8250_rx_chars(), max_count is set to 256. Due to the
> post-decrement operator used in the while() condition, the maximum
> number of iterations actually 257. This is not a problem, but it is
> mildly surprising if you're debugging. Use pre-decrement instead.

I'm somewhat inclined to changing the title to something like:

serial: 8250_core: actually limit char reads to max_count

Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/