linux-kernel - [PATCH] pcmcia: fix sign extension on 64bit machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20141014133941.2600222e@alan.etchedpixels.co.uk>
Date:	Tue, 14 Oct 2014 13:39:41 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: [PATCH] pcmcia: fix sign extension on 64bit machines

If you try and run pcmcia on a 64bit box the upper 32bits of the resource
flags all end up set due to a sign extension bug in the PCMCIA core

Signed-off-by: Alan Cox <alan@...ux.intel.com>

diff -u --new-file --recursive --exclude-from ac/.gitignore next/drivers/pcmcia/cs_internal.h ac/drivers/pcmcia/cs_internal.h
--- next/drivers/pcmcia/cs_internal.h	2013-10-28 11:40:29.717315588 +0000
+++ ac/drivers/pcmcia/cs_internal.h	2014-09-06 17:25:32.959662243 +0100
@@ -82,7 +82,7 @@
 extern int static_init(struct pcmcia_socket *s);
 extern struct resource *pcmcia_make_resource(unsigned long start,
 					unsigned long end,
-					int flags, const char *name);
+					unsigned long flags, const char *name);
 
 /*
  * Stuff internal to module "pcmcia_core":
diff -u --new-file --recursive --exclude-from ac/.gitignore next/drivers/pcmcia/rsrc_mgr.c ac/drivers/pcmcia/rsrc_mgr.c
--- next/drivers/pcmcia/rsrc_mgr.c	2013-10-28 11:40:29.721315588 +0000
+++ ac/drivers/pcmcia/rsrc_mgr.c	2014-09-06 17:24:51.671663325 +0100
@@ -31,7 +31,7 @@
 }
 
 struct resource *pcmcia_make_resource(unsigned long start, unsigned long end,
-				int flags, const char *name)
+				unsigned long flags, const char *name)
 {
 	struct resource *res = kzalloc(sizeof(*res), GFP_KERNEL);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/