lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 14 Oct 2014 14:44:10 +0200
From:	Krzysztof Kozlowski <>
To:	Vinod Koul <>
Cc:	Lars-Peter Clausen <>,
	Dan Williams <>,
	Michal Simek <>,
	Dan Carpenter <>,,,
	Kyungmin Park <>,
	Marek Szyprowski <>,
	Bartlomiej Zolnierkiewicz <>
Subject: Re: [RESEND PATCH v2 1/4] dmaengine: pl330: Remove non-NULL check for
 pl330_submit_req parameters

On wto, 2014-10-14 at 17:21 +0530, Vinod Koul wrote:
> On Mon, Sep 29, 2014 at 02:42:18PM +0200, Krzysztof Kozlowski wrote:
> > The pl330_submit_req() checked supplied 'struct pl330_thread thrd' and
> > 'struct dma_pl330_desc desc' parameters for non-NULL. However these
> > checks are useless because supplied arguments won't be NULL.
> even if we have some error or bug?
> I would like this to be checked and complained loudly so we know something
> is going wrong rather than assuming it will be correct always.

Currently the driver would fail before or after, regardless of this
check. However I do not insist on this approach.

The first version of patch was little different:

Do you think that 1st version is worth resending?

Best regards,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists