lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 14 Oct 2014 18:04:29 -0300
From:	Arnaldo Carvalho de Melo <>
To:	Ingo Molnar <>
	Arnaldo Carvalho de Melo <>,
	Adrian Hunter <>,
	Don Zickus <>,
	Douglas Hatch <>,
	Ingo Molnar <>, Jiri Olsa <>,
	Namhyung Kim <>,
	Paul Mackerras <>,
	Peter Zijlstra <>,
	Scott J Norton <>,
	Waiman Long <>
Subject: [PATCH 20/24] perf machine: Add missing dsos->root rbtree root initialization

From: Arnaldo Carvalho de Melo <>

A segfault happens on 'perf test hists_link' because we end up using a
struct machines on the stack, and then machines__init() was not
initializing the newly introduced rb_root, just the existing list_head.

When we introduced struct dsos, to group the two ways to store dsos,
i.e. the linked list and the rbtree, we didn't turned the initialization
done in:

	machines__init(machines->host) ->
		machine__init() ->

into a dsos__init() to keep on initializing the list_head but _as well_
initializing the rb_root, oops.

All worked because outside perf-test we probably zalloc the whole thing
which ends up initializing it in to NULL.

So the problem looks contained to 'perf test' that uses it on stack,

Reported-by: Jiri Olsa <>
Acked-by: Waiman Long <>,
Cc: Adrian Hunter <>,
Cc: Don Zickus <>
Cc: Douglas Hatch <>
Cc: Ingo Molnar <>
Cc: Jiri Olsa <>
Cc: Namhyung Kim <>
Cc: Paul Mackerras <>
Cc: Peter Zijlstra <>
Cc: Scott J Norton <>
Cc: Waiman Long <>,
Signed-off-by: Arnaldo Carvalho de Melo <>
 tools/perf/util/machine.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index b7d477fbda02..34fc7c8672e4 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -13,12 +13,18 @@
 #include <symbol/kallsyms.h>
 #include "unwind.h"
+static void dsos__init(struct dsos *dsos)
+	INIT_LIST_HEAD(&dsos->head);
+	dsos->root = RB_ROOT;
 int machine__init(struct machine *machine, const char *root_dir, pid_t pid)
-	INIT_LIST_HEAD(&machine->user_dsos.head);
-	INIT_LIST_HEAD(&machine->kernel_dsos.head);
+	dsos__init(&machine->user_dsos);
+	dsos__init(&machine->kernel_dsos);
 	machine->threads = RB_ROOT;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

Powered by blists - more mailing lists