[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20141014154349.ca831a4d1e5c1747779552ec@linux-foundation.org>
Date: Tue, 14 Oct 2014 15:43:49 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Heinrich Schuchardt <xypron.glpk@....de>
Cc: Jan Kara <jack@...e.cz>, Alexander Viro <viro@...iv.linux.org.uk>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Eric Paris <eparis@...isplace.org>,
John McCutchan <john@...nmccutchan.com>,
Robert Love <rlove@...ve.org>,
Michael Kerrisk <mtk.manpages@...il.com>
Subject: Re: [PATCH 1/1] fallocate: create FAN_MODIFY and IN_MODIFY events
On Tue, 07 Oct 2014 20:24:02 +0200 Heinrich Schuchardt <xypron.glpk@....de> wrote:
> Hello Andrew,
>
> the patch in
> https://lkml.org/lkml/2014/10/3/56
> and cited below was reviewed by Jan Kara.
>
Jan wondered why we generate events for FALLOC_FL_KEEP_SIZE, so other
people will wonder the same thing. We should tell them. Via code
comments and/or changelogging.
Any question which a reviewer asks should be viewed as a defect in the
patch. The patch isn't finished until people can read it without
having questions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists