linux-kernel - Re: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGS+omB5tuDHFgUGvypaSfxBW-3fhVtTOyWuve-dopeEF3Em6A@mail.gmail.com>
Date:	Tue, 14 Oct 2014 15:23:54 +0800
From:	Daniel Kurtz <djkurtz@...omium.org>
To:	Heiko Stübner <heiko@...ech.de>
Cc:	Stéphane Marchesin <marcheu@...omium.org>,
	Grant Grundler <grundler@...omium.org>,
	Simon Xue <xxm@...k-chips.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	"moderated list:ARM/Rockchip SoC..." 
	<linux-arm-kernel@...ts.infradead.org>,
	"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND..." <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/3] ARM: dts: rk3288: add VOP iommu nodes

On Tue, Oct 14, 2014 at 6:33 AM, Heiko Stübner <heiko@...ech.de> wrote:
> Hi Daniel,
>
> Am Samstag, 11. Oktober 2014, 02:30:48 schrieb Daniel Kurtz:
>> Add device nodes for the VOP iommus.
>> Device nodes for other iommus will be added in later patches.
>>
>> The iommu nodes use the #iommu-cells property as described in:
>>   Documentation/devicetree/bindings/iommu/iommu.txt
>>
>> Signed-off-by: Daniel Kurtz <djkurtz@...omium.org>
>> Signed-off-by: Simon Xue <xxm@...k-chips.com>
>> ---
>>  arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
>>  1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 5950b0a..cbc92fa 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -271,6 +271,24 @@
>>               status = "disabled";
>>       };
>>
>> +     vopb_mmu: iommu@...f930300 {
>
> please use the address without the 0x here ... iommu@...30300

I've been doing it wrong for a while and no one else noticed :-).  Thanks!
I will resend.

> Thanks
> Heiko
>
>> +             compatible = "rockchip,iommu";
>> +             reg = <0xff930300 0x100>;
>> +             interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
>> +             interrupt-names = "vopb_mmu";
>> +             #iommu-cells = <0>;
>> +             status = "disabled";
>> +     };
>> +
>> +     vopl_mmu: iommu@...f940300 {
>> +             compatible = "rockchip,iommu";
>> +             reg = <0xff940300 0x100>;
>> +             interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
>> +             interrupt-names = "vopl_mmu";
>> +             #iommu-cells = <0>;
>> +             status = "disabled";
>> +     };
>> +
>>       gic: interrupt-controller@...01000 {
>>               compatible = "arm,gic-400";
>>               interrupt-controller;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/