linux-kernel - RE: [PATCHv4] serial: of-serial: fix up PM ops on no_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b7caa34e784a47dfa585cea66ebfbb69@BL2PR03MB467.namprd03.prod.outlook.com>
Date:	Wed, 15 Oct 2014 07:16:33 +0000
From:	Jingchang Lu <jingchang.lu@...escale.com>
To:	Joseph Lo <josephl@...dia.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"peter@...leysoftware.com" <peter@...leysoftware.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCHv4] serial: of-serial: fix up PM ops on no_console_suspend
 and port type

>-----Original Message-----
>From: Joseph Lo [mailto:josephl@...dia.com]
>Sent: Wednesday, October 15, 2014 2:53 PM
>To: Lu Jingchang-B35083; gregkh@...uxfoundation.org
>Cc: linux-arm-kernel@...ts.infradead.org; linux-serial@...r.kernel.org;
>peter@...leysoftware.com; arnd@...db.de; linux-kernel@...r.kernel.org
>Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on
>no_console_suspend and port type
>
>On 10/15/2014 02:41 PM, Joseph Lo wrote:
>> On 10/15/2014 02:32 PM, Jingchang Lu wrote:
>>>> -----Original Message-----
>>>> From: Joseph Lo [mailto:josephl@...dia.com]
>>>> Sent: Wednesday, October 15, 2014 9:01 AM
>>>> To: Lu Jingchang-B35083; gregkh@...uxfoundation.org
>>>> Cc: peter@...leysoftware.com; arnd@...db.de;
>>>> linux-kernel@...r.kernel.org; linux-serial@...r.kernel.org;
>>>> linux-arm-kernel@...ts.infradead.org
>>>> Subject: Re: [PATCHv4] serial: of-serial: fix up PM ops on
>>>> no_console_suspend and port type
>>>>
>>>> On 10/14/2014 04:42 PM, Jingchang Lu wrote:
>>>>> This patch fixes commit 2dea53bf57783f243c892e99c10c6921e956aa7e,
>>>>> "serial: of-serial: add PM suspend/resume support", which disables
>>>>> the uart clock on suspend, but also causes a hardware hang on
>>>>> register access if no_console_suspend command line option is used.
>>>>>
>>>>> Also, not every of_serial device is an 8250 port, so the serial8250
>>>>> suspend/resume functions should only be applied to a real 8250 port.
>>>>>
>>>>> Signed-off-by: Jingchang Lu <jingchang.lu@...escale.com>
>>>>
>>>> If you can make sure this patch can build without include
>>>> <linux/console.h>, then this patch
>>> The build passes on my cloned linux-next tree, include next-20141014,
>>> but is required on my another kernel-3.12+ based tree, then I didn't
>>> add this header file when upstream.
>>> Is the build broken on your source tree, and is the tree latest?
>>> If the header is needed, I will add it.
>> I tested it on next-20141013 and k3.14, both of them need the fix. I
>> can check it again against the latest linux-next tree later. Thanks.
>>
>OK, I confirmed it. You should add the header file. It also doesn't build
>for me with the latest linux-next tree. Maybe you missed to enable
>CONFIG_PM_SLEEP or CONFIG_SERIAL_8250 when doing the build test in linux-
>next tree.
I have sent out the v5 patch with last git-send-email command line,
didn't realized the missing of your email address in the cc list when sending.
Please help review the v5 patch. Thanks.

Best Regards,
Jingchang
>
>-Joseph