lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20141015090410.GA9900@lee--X1>
Date:	Wed, 15 Oct 2014 11:04:10 +0200
From:	Lee Jones <lee.jones@...aro.org>
To:	Will Sheppard <wsheppard@...edded-bits.co.uk>
Cc:	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] mfd: arizona-spi: Add lines after declarations -
 checkpatch catch

On Wed, 15 Oct 2014, Will Sheppard wrote:

> This was found whilst running checkpatch.pl on arizona-spi.
> 
> WARNING: Missing a blank line after declarations
> +       struct arizona *arizona = spi_get_drvdata(spi);
> +       arizona_dev_exit(arizona);
> 
> Signed-off-by: Will Sheppard <wsheppard@...edded-bits.co.uk>
> ---
>  drivers/mfd/arizona-spi.c | 2 ++
>  1 file changed, 2 insertions(+)

Applied for v3.19.

> diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
> index 5145d78..8ef58bc 100644
> --- a/drivers/mfd/arizona-spi.c
> +++ b/drivers/mfd/arizona-spi.c
> @@ -75,7 +75,9 @@ static int arizona_spi_probe(struct spi_device *spi)
>  static int arizona_spi_remove(struct spi_device *spi)
>  {
>  	struct arizona *arizona = spi_get_drvdata(spi);
> +
>  	arizona_dev_exit(arizona);
> +
>  	return 0;
>  }
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ