linux-kernel - Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1413378213.2412.13.camel@jtkirshe-mobl>
Date:	Wed, 15 Oct 2014 06:03:33 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

On Wed, 2014-10-15 at 15:59 +0300, Dan Carpenter wrote:
> Or we could fix it but add a multi-line comment with lots of capital
> letters and exclamation marks.  I guess we would need to make a
> function
> since this cast is in several places.
> 
> void *silence_buggy_casting(u32 pointer)
> {
>         /*
>          * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
>          * FIXME!!!  We know this cast is totally buggy.  The BCM
> driver
>          * doesn't work on 64 bits.  But no one knows how to make this
>          * work.  Oh well.  Let's silence the GCC warning.
>          * DANGER! DANGER! DANGER! DANGER! DANGER! DANGER! DANGER!
>          *
>          */
>         return (void *)(long)pointer;
> }
> 
> Something really ugly and gnarly like that would be hard to ignore.

I thought I remember Greg saying something about getting rid of this
driver anyway, but I could be wrong.  If Greg decides to keep this
driver around, then I think we should something like your suggestion
above.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)