linux-kernel - Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2014 14:15:51 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Aaron Lu <aaron.lu@...el.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Bryan Wu <cooloney@...il.com>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Darren Hart <dvhart@...ux.intel.com>
Subject: Re: [PATCH v4 00/13] Add ACPI _DSD and unified device properties
 support

On Wed, Oct 15, 2014 at 02:04:31PM +0100, David Woodhouse wrote:
> Here's a completely untested patch to convert of_serial to be usable via
> ACPI properties too. The properties themselves were fairly
> straightforward; the interesting part is converting to
> platform_get_irq() and platform_get_resource() — in the latter case
> first trying IORESOURCE_MEM then IORESOURCE_IO if that fails.
> 
> Does this look sane? We'll probably want to think about renaming the
> module and the config option too, but that can come after the basic
> functionality.

The majority of these properties look like they constrained to the
device in question, so make sense for _DSD too.

However...

> @@ -155,7 +168,7 @@ static int of_platform_serial_probe(struct platform_device *ofdev)
>  	if (!match)
>  		return -EINVAL;
>  
> -	if (of_find_property(ofdev->dev.of_node, "used-by-rtas", NULL))
> +	if (!device_get_property(&ofdev->dev, "used-by-rtas", NULL))
>  		return -EBUSY;

This property should never be present on an ACPI system. RTAS is a
completely different firmware interface on PowerPC.

As a general note, I would hope that we're not going to blindly convert
drivers and subsystems over to a common property interface without
considering each property w.r.t. the particular FW interface. 

Each addition to _DSD, especially if through a common accessor needs
_more_ scrutiny than is applied to DT bindings, and we hardly manage to
review DT bindings.

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/