linux-kernel - Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2014 10:08:23 -0700
From:	Zach Brown <zab@...bo.net>
To:	Fabian Frederick <fabf@...net.be>
Cc:	Josef Bacik <jbacik@...com>, linux-kernel@...r.kernel.org,
	linux-btrfs@...r.kernel.org, Chris Mason <clm@...com>
Subject: Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

On Tue, Oct 14, 2014 at 10:18:09PM +0200, Fabian Frederick wrote:
> 
> 
> > On 14 October 2014 at 21:15 Zach Brown <zab@...bo.net> wrote:
> >
> >
> > On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote:
> > > use function defined in include/linux/highmem.h
> > > Note that this reverts 2 last function call order
> >
> > And adds a BUG_ON(PAGE_CACHE_SIZE > PAGE_SIZE).  We can take bets on
> > whether that will ever trigger.
> 
> There are 36 zero_user_segment with PAGE_CACHE_SIZE callsites.
> Maybe we could add some specific function to avoid BUG_ON tests ?

Nah, I wouldn't bother.

A lot of us have long rolled our eyes at the distinction between
PAGE_SIZE and PAGE_CACHE_SIZE given how much will break if they're ever
actually different.  That's what I was referencing there :).

- z 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/