[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20141015125000.44353284288395e216659953@linux-foundation.org>
Date: Wed, 15 Oct 2014 12:50:00 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Joe Perches <joe@...ches.com>
Cc: Andy Whitcroft <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] checkpatch: Add error on use of attribute((weak))
or __weak
On Wed, 15 Oct 2014 12:45:48 -0700 Joe Perches <joe@...ches.com> wrote:
> On Wed, 2014-10-15 at 12:42 -0700, Andrew Morton wrote:
> > On Wed, 15 Oct 2014 12:32:08 -0700 Joe Perches <joe@...ches.com> wrote:
> >
> > > Using weak can have unintended link defects.
> > > Emit an error on its use.
> >
> > Well, we don't want a warning about use of __weak in function
> > definitions. Only in declarations.
>
> Why is that?
Because the problem we're trying to detect is when __weak is used on a
declaration.
This is OK:
foo.h:
extern int foo(void);
foo.c:
int __weak foo(void)
{
...
}
But this is not OK:
foo.h:
extern __weak int foo(void);
foo.c:
int __weak foo(void)
{
...
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists