linux-kernel - Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Oct 2014 13:26:07 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org,
	Fabio Estevam <fabio.estevam@...escale.com>,
	linux-kernel@...r.kernel.org, mail@...ermatthias.de,
	devel@...verdev.osuosl.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote:
> On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote:
> > From: Fabio Estevam <fabio.estevam@...escale.com>
> > 
> > The Beceem WIMAX was generating compile warnings on 64bit machines,
> > which were:
> > 
> > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> >    ^
> > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> >    ^
> > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> >    (struct bcm_connect_mgr_params *) ntohl(
> > 
> > This resolves the issue by preventing the driver to compile if CONFIG_64BIT
> > is enabled, since the driver is known to be broken for 64 bit arch's.
> > 
> 
> Oops.  Someone turned a Joe patch into a real patch.  Please enable
> COMPILE_TEST for this.

I agree with Joe, that COMPILE_TEST is not useful for this driver.

> 
> regards,
> dan carpenter
> 



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)