linux-kernel - Re: [PATCH] spi/atmel: add support for runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141016073004.GL27755@sirena.org.uk>
Date:	Thu, 16 Oct 2014 09:30:04 +0200
From:	Mark Brown <broonie@...nel.org>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	nicolas.ferre@...el.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] spi/atmel: add support for runtime PM

On Thu, Oct 16, 2014 at 09:49:20AM +0800, Wenyou Yang wrote:

> +static int atmel_spi_runtime_resume(struct device *dev)
> +{
> +	struct spi_master *master = dev_get_drvdata(dev);
> +	struct atmel_spi *as = spi_master_get_devdata(master);
> +
> +	pinctrl_pm_select_default_state(dev);
> +	clk_prepare_enable(as->clk);
> +

This looks mostly good but you should check the return value of
clk_prepare_enable() - it can fail.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)