linux-kernel - Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141016075211.GE23154@mwanda>
Date:	Thu, 16 Oct 2014 10:52:11 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

On Wed, Oct 15, 2014 at 01:26:07PM -0700, Jeff Kirsher wrote:
> On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote:
> > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote:
> > > From: Fabio Estevam <fabio.estevam@...escale.com>
> > > 
> > > The Beceem WIMAX was generating compile warnings on 64bit machines,
> > > which were:
> > > 
> > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmControlResponseMessage’:
> > > drivers/staging/bcm/CmHost.c:1503:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > >    (struct bcm_connect_mgr_params *) ntohl(
> > >    ^
> > > drivers/staging/bcm/CmHost.c:1546:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > >    (struct bcm_connect_mgr_params *) ntohl(
> > >    ^
> > > drivers/staging/bcm/CmHost.c:1564:3: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> > >    (struct bcm_connect_mgr_params *) ntohl(
> > > 
> > > This resolves the issue by preventing the driver to compile if CONFIG_64BIT
> > > is enabled, since the driver is known to be broken for 64 bit arch's.
> > > 
> > 
> > Oops.  Someone turned a Joe patch into a real patch.  Please enable
> > COMPILE_TEST for this.
> 
> I agree with Joe, that COMPILE_TEST is not useful for this driver.

If we remove the driver fine, but if we keep the driver then we should
do enable any QA testing we can.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/