linux-kernel - Re: [PATCH] [kernel]: process: replace printk with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2484936.7PAAKpDVM2@vostro.rjw.lan>
Date:	Thu, 16 Oct 2014 10:37:50 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Vishnu Pratap Singh <vishnu.ps@...sung.com>
Cc:	akpm@...ux-foundation.org, len.brown@...el.com, pavel@....cz,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	cpgs@...sung.com, pintu.k@...sung.com, vishu13285@...il.com
Subject: Re: [PATCH] [kernel]: process: replace printk with pr_err

On Thursday, October 16, 2014 10:36:35 AM Vishnu Pratap Singh wrote:
> This patch replaces printk(KERN_ERR...) with pr_err found.

What is the reason?  Does the existing code cause any problems to happen?

> Signed-off-by: Vishnu Pratap Singh <vishnu.ps@...sung.com>
> ---
>  kernel/power/process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/power/process.c b/kernel/power/process.c
> index 7b32322..401f7ee 100644
> --- a/kernel/power/process.c
> +++ b/kernel/power/process.c
> @@ -85,7 +85,7 @@ static int try_to_freeze_tasks(bool user_only)
>  
>  	if (todo) {
>  		printk("\n");
> -		printk(KERN_ERR "Freezing of tasks %s after %d.%03d seconds "
> +		pr_err("Freezing of tasks %s after %d.%03d seconds "
>  		       "(%d tasks refusing to freeze, wq_busy=%d):\n",
>  		       wakeup ? "aborted" : "failed",
>  		       elapsed_msecs / 1000, elapsed_msecs % 1000,
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/