linux-kernel - Re: [PATCH] regulator: s2mps11: Don't zero allocated memory for external control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141016084937.GH724@sirena.org.uk>
Date:	Thu, 16 Oct 2014 10:49:37 +0200
From:	Mark Brown <broonie@...nel.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Sangbeom Kim <sbkim73@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: s2mps11: Don't zero allocated memory for
 external control

On Thu, Oct 16, 2014 at 10:23:28AM +0200, Krzysztof Kozlowski wrote:
> The driver was allocating memory for storing GPIOs for external control
> with unnecessary GFP_ZERO flag. Then right after allocation it
> initialized memory to -EINVAL in loop. Skip the GFP_ZERO flag.

Applied, though it's a bit of a microptimisation and it would be better
to use kmalloc_array() instead.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)